Merged
Conversation
Contributor
Author
|
Interestingly I can't replicate this when I run the same |
Contributor
Author
|
Since the offending link is in Moreover: it is adjacent to a slightly different WORKING link for ECMWF, so I have decided to remove the broken one rather than just ignore it during link checks - we get very little benefit by keeping it, but risk the link going silently stale in future. |
ESadek-MO
requested changes
Jan 9, 2023
Contributor
ESadek-MO
left a comment
ESadek-MO
left a comment
There was a problem hiding this comment.
Hey @trexfeathers, this looks good! Would perhaps make the Whatsnew entry more specific, then I think this would be good to go!
ESadek-MO
approved these changes
Jan 9, 2023
Contributor
Author
|
Thanks @ESadek-MO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Since the offending link is in
whatsnew/1.0.rst, and is proving difficult to debug (only a problem on GHA), I'd say it's not worth fixing.Moreover: it is adjacent to a slightly different WORKING link for ECMWF, so I have decided to remove the broken one rather than just ignore it during link checks - we get very little benefit by keeping it, but risk the link going silently stale in future.
Consult Iris pull request check list